Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement parsing of workflow config from a yaml file #17

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

agoscinski
Copy link
Collaborator

We use pydantic to define a schema for the workflow config that can be used to parse a yaml file following the schema.

We provide a function to parse from a yaml file using pydantic-yaml.

@agoscinski agoscinski requested a review from leclairm September 20, 2024 09:33
We use pydantic to define a schema for the workflow config that can be
used to parse a yaml file following the schema.

We provide a function to parse from a yaml file using pydantic-yaml.
@GeigerJ2 GeigerJ2 self-requested a review October 8, 2024 11:53
Copy link
Collaborator

@GeigerJ2 GeigerJ2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

And just to showcase again the beatufil rich output of the ConfigWorkflow <3

image

src/wcflow/parsing/_yaml_data_models.py Outdated Show resolved Hide resolved
src/wcflow/parsing/_yaml_data_models.py Outdated Show resolved Hide resolved
src/wcflow/parsing/_yaml_data_models.py Outdated Show resolved Hide resolved
src/wcflow/parsing/_yaml_data_models.py Outdated Show resolved Hide resolved
src/wcflow/parsing/_yaml_data_models.py Outdated Show resolved Hide resolved
src/wcflow/parsing/_yaml_data_models.py Show resolved Hide resolved
tests/files/configs/test_config_small.yml Outdated Show resolved Hide resolved
tests/test_wc_workflow.py Outdated Show resolved Hide resolved
@agoscinski agoscinski merged commit 84e1e8a into main Oct 15, 2024
3 checks passed
@agoscinski agoscinski deleted the integrate-pydantic branch October 15, 2024 15:26
agoscinski added a commit that referenced this pull request Oct 15, 2024
We use pydantic to define a schema for the workflow config that can be
used to parse a yaml file following the schema.

We provide a function to parse from a yaml file using pydantic-yaml.
@agoscinski agoscinski mentioned this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants